Privacy Policy Links #1119
Merged
Privacy Policy Links #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the links with the way @JGreenlee and Nitish found when updating the accessibility In the dev app, all of the links work updated the TSDC link because the previous one did not seem to still be working, when I type it into a search bar I get redirected to the link I updated to
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## service_rewrite_2023 #1119 +/- ##
=====================================================
Coverage 58.80% 58.80%
=====================================================
Files 26 26
Lines 1420 1420
Branches 320 320
=====================================================
Hits 835 835
Misses 585 585
Flags with carried forward coverage won't be shown. Click here to find out more. |
JGreenlee
approved these changes
Jan 3, 2024
|
When testing, I did find that the |
For the record, the android build succeeded on rebuild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated links with the new method from here
I changed the TSDC link from https://www.nrel.gov/tsdc to https://www.nrel.gov/transportation/secure-transportation-data/ since the older link did not seem to be working, and was redirecting me to the second link.
The rest of the links are working in the dev app
Remaining would be to update some/all of the emails to be clickable.